This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Added a more complete docstring for SemanticsFlags #19817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
approved these changes
Jul 16, 2020
| // Must match the SemanticsFlags enum in semantics.dart. | ||
| /// C/C++ representation of `SemanticsFlags` defined in | ||
| /// `lib/ui/semantics.dart`. | ||
| ///\warning This must match the `SemanticsFlags` enum in |
There was a problem hiding this comment.
It's doxygen commands which is what we use for c/c++/objc documentation: https://www.doxygen.nl/manual/commands.html
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2020
Hixie
reviewed
Dec 1, 2021
Comment on lines
+11
to
+16
| /// | ||
| /// \warning When changes are made to this class, the equivalent APIs in | ||
| /// `lib/ui/semantics/semantics_node.h` and in each of the embedders | ||
| /// *must* be updated. | ||
| /// See also: | ||
| /// - file://./../../lib/ui/semantics/semantics_node.h |
There was a problem hiding this comment.
looks like this didn't do what we hoped:
https://master-api.flutter.dev/flutter/dart-ui/SemanticsAction-class.html
There was a problem hiding this comment.
A couple of years later... #52229
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.